Repository navigation
Refuse a claim of absence on a lock screen, and ref a list's wrapper (CHALLENGES 391, 392) - #336
Merged
Merged
Conversation
…(CHALLENGES 391, 392) On the iOS 26.5 simulator, wait --for hidden, --not and --count 0 answered exit 0 on a locked device, and a timeout never named the lock. They now answer device_not_ready, as do find and text on a miss. Android already refused them. wait testid=table gave Android the list's ref and iOS none: React Native on iOS puts the testID on a plain view on the list's exact rectangle. Such a wrapper now takes the ref. A wrapper around a smaller control does not, since its ref would touch something else. lock.sh and wait-states.sh fail on main on the iOS simulator and pass here on both platforms. locators passes on both; mobium-app and dialogs on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps from the verification comments on #327 and #329.
A wait on a locked iOS device (391)
iOS reads its lock screen, so a target is simply absent from it. Three forms of
waitreported success about an app nobody could see, and the rest never named the lock.wait X --for hiddenwait X --notwait X --for count --count 0wait Xfind Xtext XAndroid already refused all six. A wait to show still runs its timeout, for a person unlocking by hand. On an unlocked home screen these answer as before.
wait testid=table(392)Android gave
@e2 table (list)and iOS(no ref) table. This is not a regression from #330: before it, iOS returned no element at all. React Native on iOS puts the testID on a plain view around the ScrollView, on exactly the same rectangle.A match the map filters out now takes the ref of the one mapped element on its own rectangle, in
wait,scroll-toandfind. A wrapper around a smaller control still has no ref, since its ref would touch something other than what matched. iOS still labels itScrollViewwhere Android saystable.Measured
lock.shandwait-states.shfail onmainon the iOS simulator and pass here on both platforms.locatorspasses on both;mobium-appanddialogson iOS.Not settled here